Switch to using stock gcovr 5.2 #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
yxieca
approved these changes
Dec 20, 2022
This was referenced Dec 20, 2022
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-sairedis
that referenced
this pull request
Dec 27, 2022
* Test using stock gcovr Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Use gcovr 5.2 Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
bingwang-ms
pushed a commit
to bingwang-ms/sonic-sairedis
that referenced
this pull request
Jan 2, 2023
* Test using stock gcovr Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Use gcovr 5.2 Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
bingwang-ms
added a commit
that referenced
this pull request
Jan 2, 2023
|
I opened another PR to backport the change into 202205 branch. #1190 |
liushilongbuaa
pushed a commit
to liushilongbuaa/sonic-sairedis
that referenced
this pull request
Jan 4, 2023
* Test using stock gcovr Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
liushilongbuaa
pushed a commit
to liushilongbuaa/sonic-sairedis
that referenced
this pull request
Jan 4, 2023
* Test using stock gcovr Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Use gcovr 5.2 Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
StormLiangMS
pushed a commit
that referenced
this pull request
Feb 10, 2023
* Test using stock gcovr Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Use gcovr 5.2 Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
liushilongbuaa
pushed a commit
to liushilongbuaa/sonic-sairedis
that referenced
this pull request
Mar 13, 2023
* Test using stock gcovr Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Use gcovr 5.2 Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom branch we were using previously has since been deleted. That branch appears to have some fix for searching for the source file (for a gcda file) recursively. I don'y know if it's needed or not today, but using the stock gcovr 5.2 (from the official repo) appears to work.
Signed-off-by: Saikrishna Arcot sarcot@microsoft.com